Skip to content

Fix 409 for missed pages #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2025
Merged

Conversation

skryukov
Copy link
Contributor

@skryukov skryukov commented Apr 1, 2025

This PR fixes #205 plus introduces the with_inertia_config test helper and turns on :random order for RSpec.

Copy link
Collaborator

@bknoles bknoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

after {
InertiaRails.configure { |config| config.deep_merge_shared_data = false }
}
with_inertia_config deep_merge_shared_data: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much nicer

@bknoles bknoles merged commit efc9ec8 into inertiajs:master Apr 10, 2025
17 checks passed
@skryukov skryukov deleted the fix-409-for-missed-pages branch April 10, 2025 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

409 instead of 404 when requesting a non-existent route
2 participants